Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: ignore broken pypi combination #3043

Merged
merged 3 commits into from Sep 27, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Sep 27, 2022

Currently protobuf 3.19.5 is pretty much broken, and the latest version that is usuable
and not break stub is 3.19.4

this means that we can't also have to restrict grpcio not to use 1.48.2

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner September 27, 2022 16:59
@aarnphm aarnphm requested review from parano and removed request for a team September 27, 2022 16:59
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3043 (3590d2f) into main (a666072) will increase coverage by 1.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3043      +/-   ##
==========================================
+ Coverage   60.65%   61.75%   +1.10%     
==========================================
  Files         132      132              
  Lines       11472    11477       +5     
  Branches     1913     1914       +1     
==========================================
+ Hits         6958     7088     +130     
+ Misses       4087     3959     -128     
- Partials      427      430       +3     
Impacted Files Coverage Δ
bentoml/_internal/configuration/containers.py 69.29% <0.00%> (-0.59%) ⬇️
bentoml/bentos.py 66.95% <0.00%> (ø)
bentoml/_internal/runner/runner.py 85.45% <0.00%> (+1.81%) ⬆️
bentoml/_internal/models/model.py 85.43% <0.00%> (+1.98%) ⬆️
bentoml/_internal/utils/lazy_loader.py 79.41% <0.00%> (+2.94%) ⬆️
bentoml/_internal/runner/runner_handle/local.py 80.00% <0.00%> (+4.00%) ⬆️
bentoml/_internal/runner/strategy.py 86.44% <0.00%> (+10.16%) ⬆️
bentoml/_internal/frameworks/common/pytorch.py 69.47% <0.00%> (+69.47%) ⬆️
bentoml/_internal/frameworks/torchscript.py 92.00% <0.00%> (+92.00%) ⬆️

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
pyproject.toml Outdated Show resolved Hide resolved
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm changed the title chore: ignore specific broken pypi release dependencies: ignore broken pypi combination Sep 27, 2022
@aarnphm aarnphm merged commit ce99e45 into bentoml:main Sep 27, 2022
@aarnphm aarnphm deleted the fix/deps-table branch September 27, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants