Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): should validate config early #3041

Merged
merged 1 commit into from Sep 27, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Sep 27, 2022

revert some of changes before #3018

@aarnphm aarnphm requested a review from a team as a code owner September 27, 2022 15:23
@aarnphm aarnphm requested review from larme and removed request for a team September 27, 2022 15:23
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3041 (ea464b2) into main (a666072) will decrease coverage by 8.66%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
- Coverage   60.65%   51.98%   -8.67%     
==========================================
  Files         132      109      -23     
  Lines       11472    10354    -1118     
  Branches     1913     1758     -155     
==========================================
- Hits         6958     5383    -1575     
- Misses       4087     4688     +601     
+ Partials      427      283     -144     
Impacted Files Coverage Δ
bentoml/_internal/configuration/containers.py 59.44% <40.00%> (-10.44%) ⬇️
bentoml/_internal/server/runner_app.py 0.00% <0.00%> (-93.13%) ⬇️
bentoml/_internal/runner/runner_handle/remote.py 0.00% <0.00%> (-82.66%) ⬇️
bentoml/_internal/marshal/dispatcher.py 0.00% <0.00%> (-77.85%) ⬇️
bentoml/_internal/runner/runner_handle/local.py 0.00% <0.00%> (-76.00%) ⬇️
bentoml/_internal/server/http/instruments.py 25.00% <0.00%> (-64.43%) ⬇️
bentoml/_internal/server/http/access.py 27.53% <0.00%> (-57.98%) ⬇️
bentoml/_internal/utils/alg.py 0.00% <0.00%> (-51.22%) ⬇️
bentoml/_internal/log.py 32.81% <0.00%> (-46.88%) ⬇️
bentoml/_internal/bento/build_dev_bentoml_whl.py 32.43% <0.00%> (-43.25%) ⬇️
... and 50 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Copy link
Collaborator

@ssheng ssheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some unit tests are still failing.

@aarnphm aarnphm merged commit d189df7 into bentoml:main Sep 27, 2022
@aarnphm aarnphm deleted the fix/configuration branch September 27, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants