docs: gRPC advanced guides #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3034 +/- ##
=======================================
Coverage 62.29% 62.29%
=======================================
Files 131 131
Lines 11321 11321
Branches 1873 1873
=======================================
Hits 7052 7052
Misses 3842 3842
Partials 427 427
|
aarnphm
force-pushed
the
docs/grpc-server-info
branch
10 times, most recently
from
047568b
to
5ff7793
Compare
aarnphm
commented
Sep 25, 2022
Comment on lines
+41
to
+48
| width: 50em; | ||
| } | ||
|
|
||
| .sidebar-drawer { | ||
| width: calc(45% - 26em); | ||
| } | ||
|
|
There was a problem hiding this comment.
Makes t docs a tad bit bigger.
ssheng
reviewed
Sep 25, 2022
docs/source/guides/grpc.rst
Outdated
Comment on lines
1055
to
1070
| With support for :ref:`multiplexing <guides/grpc:Demystifying the misconception of gRPC vs. REST>` | ||
| to eliminate :wiki:`head-of-line blocking <Head-of-line_blocking>`, | ||
| gPRC enables us to mount additional custom servicess alongside with BentoService, | ||
| and serve them under the same port. |
There was a problem hiding this comment.
Mounting services is independent of multiplexing and head of line blocking. Only that gRPC multiplexing makes it nicer so that one service does not block another service.
Also, there is a typo in "servicess".
There was a problem hiding this comment.
Isn't that the purpose of service multiplexing? is that multiple services can be served under the same port?
There was a problem hiding this comment.
You can technically do that in http/1 without multiplexing, like uvicorn.
There was a problem hiding this comment.
but i guess it is not support ootb
parano
reviewed
Sep 25, 2022
aarnphm
force-pushed
the
docs/grpc-server-info
branch
3 times, most recently
from
0393c6b
to
0f50e30
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
also just slightly bigger div for contents container Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
make sure to include protobuf in the requirements Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
docs/grpc-server-info
branch
from
7081b8d
to
eb71f1a
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
docs/grpc-server-info
branch
from
f011823
to
9aec87c
Compare
ssheng
reviewed
Sep 27, 2022
ssheng
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advanced guides
Provide snippets to quickly test and run client implementation with bazel.