feat: gRPC tracking #3015
Merged
feat: gRPC tracking #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
commented
Sep 20, 2022
Comment on lines
+358
to
+366
| Example Usage: (To reuse the container based on the same image) | ||
|
|
||
| .. code-block:: python | ||
|
|
||
| @cached_contextmanager("{docker_image.id}") | ||
| def start_docker_container_from_image(docker_image, timeout=60): | ||
| container = ... | ||
| yield container | ||
| container.stop() |
There was a problem hiding this comment.
update documentation how to use this decorator.
Comment on lines
+69
to
+74
| if get_debug_mode(): | ||
| logger.error( | ||
| f"Tracking Error: {err}", stack_info=True, stacklevel=3 | ||
| ) | ||
| else: | ||
| logger.info(f"Tracking Error: {err}") |
There was a problem hiding this comment.
Showing stack when BENTOML_DEBUG=True
aarnphm
force-pushed
the
grpc/tracking
branch
3 times, most recently
from
01bc401
to
91493b2
Compare
Codecov Report
@@ Coverage Diff @@
## main #3015 +/- ##
==========================================
+ Coverage 62.29% 62.33% +0.04%
==========================================
Files 131 132 +1
Lines 11321 11522 +201
Branches 1873 1983 +110
==========================================
+ Hits 7052 7182 +130
- Misses 3842 3905 +63
- Partials 427 435 +8
|
aarnphm
force-pushed
the
grpc/tracking
branch
2 times, most recently
from
0c9481a
to
23f7492
Compare
aarnphm
commented
Sep 26, 2022
| @@ -56,6 +56,7 @@ def prometheus_client(self): | |||
|
|
|||
| # step 2: | |||
| import prometheus_client | |||
| import prometheus_client.parser | |||
There was a problem hiding this comment.
This changes is to make sure we don't import prometheus_client.parser again.
aarnphm
commented
Sep 26, 2022
ssheng
reviewed
Sep 27, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
grpc/tracking
branch
from
4db6f76
to
9857585
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
ssheng
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com
What does this PR address?
Fixes #2991
Depends on #2984
Before submitting:
guide on how to create a pull request.
make formatandmake lintscript have passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.