Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: cleanup MLflow #2945

Merged
merged 2 commits into from Sep 27, 2022
Merged

qa: cleanup MLflow #2945

merged 2 commits into from Sep 27, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Aug 26, 2022

Cleanup some logic, qa with local postgres, mysql setup of mlflow registry.
cleanup some types as well.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from ssheng August 26, 2022 07:02
@aarnphm aarnphm requested a review from a team as a code owner August 26, 2022 07:02
@aarnphm aarnphm requested review from sauyon and removed request for a team August 26, 2022 07:02
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #2945 (7d208e9) into main (d3d9cdb) will increase coverage by 1.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
+ Coverage   68.99%   70.60%   +1.61%     
==========================================
  Files         122      104      -18     
  Lines       10131     9564     -567     
==========================================
- Hits         6990     6753     -237     
+ Misses       3141     2811     -330     
Impacted Files Coverage Δ
bentoml/_internal/frameworks/mlflow.py 91.42% <100.00%> (-0.13%) ⬇️
bentoml/_internal/frameworks/torchscript.py 0.00% <0.00%> (-96.00%) ⬇️
bentoml/_internal/frameworks/common/pytorch.py 0.00% <0.00%> (-72.64%) ⬇️
bentoml/_internal/runner/strategy.py 83.05% <0.00%> (-8.48%) ⬇️
bentoml/_internal/runner/runner_handle/local.py 76.00% <0.00%> (-8.00%) ⬇️
bentoml/_internal/frameworks/keras.py 84.25% <0.00%> (-5.84%) ⬇️
bentoml/_internal/server/runner_app.py 95.32% <0.00%> (-2.64%) ⬇️
bentoml/_internal/models/model.py 88.41% <0.00%> (-1.66%) ⬇️
bentoml/_internal/runner/runner.py 90.90% <0.00%> (-0.91%) ⬇️
bentoml/_internal/utils/analytics/usage_stats.py 96.42% <0.00%> (ø)
... and 22 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit b3bd5a7 into bentoml:main Sep 27, 2022
@aarnphm aarnphm deleted the qa/mlflow branch September 27, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants