From d7efca1f3c520a61b2be5df0cbd93484543d9ca4 Mon Sep 17 00:00:00 2001 From: Aaron Pham <29749331+aarnphm@users.noreply.github.com> Date: Mon, 26 Sep 2022 01:39:38 -0700 Subject: [PATCH] chore: format and lint make sure to include protobuf in the requirements Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com> --- BUILD.bazel | 2 +- grpc-client/java/BUILD.bazel | 11 +++++++---- grpc-client/kotlin/BUILD.bazel | 9 ++++++--- grpc-client/python/BUILD.bazel | 6 +++++- 4 files changed, 19 insertions(+), 9 deletions(-) diff --git a/BUILD.bazel b/BUILD.bazel index d2cac078e6d..733aa2ea532 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -12,9 +12,9 @@ load("@rules_proto//proto:defs.bzl", "proto_library") proto_library( name = "service_v1alpha1_proto", srcs = ["bentoml/grpc/v1alpha1/service.proto"], + visibility = ["//grpc-client:__subpackages__"], deps = [ "@com_google_protobuf//:struct_proto", "@com_google_protobuf//:wrappers_proto", ], - visibility = ["//grpc-client:__subpackages__"], ) diff --git a/grpc-client/java/BUILD.bazel b/grpc-client/java/BUILD.bazel index 871e854626b..8742862ee04 100644 --- a/grpc-client/java/BUILD.bazel +++ b/grpc-client/java/BUILD.bazel @@ -6,7 +6,10 @@ load("@io_grpc_grpc_java//:java_grpc_library.bzl", "java_grpc_library") proto_library( name = "service_proto", srcs = ["src/main/proto/v1alpha1/service.proto"], - deps = ["@com_google_protobuf//:struct_proto", "@com_google_protobuf//:wrappers_proto"], + deps = [ + "@com_google_protobuf//:struct_proto", + "@com_google_protobuf//:wrappers_proto", + ], ) java_proto_library( @@ -21,11 +24,11 @@ java_grpc_library( ) java_library( - name="grpc-library", - srcs = glob(["src/main/java/**/*.java"],), + name = "grpc-library", + srcs = glob(["src/main/java/**/*.java"]), deps = [ - ":service_java_proto", ":service_java_grpc", + ":service_java_proto", "@io_grpc_grpc_java//api", ], ) diff --git a/grpc-client/kotlin/BUILD.bazel b/grpc-client/kotlin/BUILD.bazel index 47bf899fa7d..c0d6a1be24b 100644 --- a/grpc-client/kotlin/BUILD.bazel +++ b/grpc-client/kotlin/BUILD.bazel @@ -8,7 +8,10 @@ load("@com_github_grpc_grpc_kotlin//:kt_jvm_grpc.bzl", "kt_jvm_grpc_library", "k proto_library( name = "service_proto", srcs = ["src/main/proto/v1alpha1/service.proto"], - deps = ["@com_google_protobuf//:struct_proto", "@com_google_protobuf//:wrappers_proto"], + deps = [ + "@com_google_protobuf//:struct_proto", + "@com_google_protobuf//:wrappers_proto", + ], ) java_proto_library( @@ -24,7 +27,7 @@ kt_jvm_proto_library( kt_jvm_grpc_library( name = "service_kt_grpc", srcs = [":service_proto"], - deps = [ ":service_java_proto" ], + deps = [":service_java_proto"], ) kt_jvm_binary( @@ -32,8 +35,8 @@ kt_jvm_binary( srcs = ["src/main/kotlin/com/client/BentoServiceClient.kt"], main_class = "com.client.BentoServiceClient", deps = [ - ":service_kt_proto", ":service_kt_grpc", + ":service_kt_proto", "@com_google_protobuf//:protobuf_java_util", "@io_grpc_grpc_java//netty", ], diff --git a/grpc-client/python/BUILD.bazel b/grpc-client/python/BUILD.bazel index 4dd3148fc3e..48e45e5ee08 100644 --- a/grpc-client/python/BUILD.bazel +++ b/grpc-client/python/BUILD.bazel @@ -5,5 +5,9 @@ py_binary( name = "client", srcs = ["client.py"], python_version = "PY3", - deps = [requirement("grpcio"), requirement("bentoml")] + deps = [ + requirement("grpcio"), + requirement("bentoml"), + requirement("protobuf"), + ], )