Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default Redis port when creating configuration #2563

Open
olgeni opened this issue May 6, 2024 · 2 comments
Open

Incorrect default Redis port when creating configuration #2563

olgeni opened this issue May 6, 2024 · 2 comments
Labels
bug configuration Any tasks or issues relating to Benthos configuration documentation effort: lower A lower effort issue that should be possible to complete (relatively) quickly

Comments

@olgeni
Copy link

olgeni commented May 6, 2024

When creating a new Redis-based configuration, port 6397 is suggested rather than the default 6379:

benthos create redis_pubsub | grep url

Output:

url: redis://:6397 # No default (required)

This also applies to the website documentation, and affects redis_pubsub, redis_list, and redis_streams 😅 as a quick grep shows quite a few all around.

@mihaitodor
Copy link
Member

Hey @olgeni 👋 Nice find! I can see how that might trip people up. The docs are generated from code, so all that's needed is a small change here and then one can regenerate the docs using make docs. PRs are welcome! :)

@mihaitodor mihaitodor added documentation bug configuration Any tasks or issues relating to Benthos configuration effort: lower A lower effort issue that should be possible to complete (relatively) quickly labels May 9, 2024
@olgeni
Copy link
Author

olgeni commented May 9, 2024

Coming up as #2572 \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug configuration Any tasks or issues relating to Benthos configuration documentation effort: lower A lower effort issue that should be possible to complete (relatively) quickly
Projects
None yet
Development

No branches or pull requests

2 participants