New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) #521 trim leading and trailing empty values in parse_qs #523
Conversation
when trim_all has been added to OTP? Was it always there? |
Looks like it was added in 18. If this still needs to be compatible with < 18 we can change |
for the current major it’s needed yes. Maybe using the `re` module would do
the trick?
…On Thursday, August 30, 2018, leonardb ***@***.***> wrote:
Looks like it was added in 18. If this still needs to be compatible with <
18 we can change
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#523 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA4op4pJbYy1u9reqefpdsg4JYBA_R_ks5uV8LPgaJpZM4WFvc_>
.
--
Sent from my Mobile
|
Do we really support < 18? c29aec2#diff-354f30a63fb0907d4ad57269548329e3 |
I'm not sure if we can achieve this reliably and safely using a regex. If we want to do this safely I could always extract the binary:split/3 logic/code from 18 into a local function as a stop-gap until you decide to formally drop support for < 18 |
Indeed. Doing it would allows us to include the change in 1.x directly, with a proper note to remove that hack in coming 2.x release. @edgurgel hackney is still supposed to work on 17.x and sup. even if not advised. That support will be officially removed in 2.x . |
@benoitc Which module would you prefer this to be in?
|
Right :) I think |
@benoitc Ready for review |
@leonardb thanks!, changes looked good, merged it :) release will happen later today |
Fixes crash in parse_qs when qs contains extra ampersands