Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

sockname and peername access from hackney module #504

Merged
merged 8 commits into from Sep 1, 2018

Conversation

c-bik
Copy link
Contributor

@c-bik c-bik commented Apr 26, 2018

Hi @benoitc,

First off great job 馃憤. This application has more useful features than most other http clients out there (including httpc).

Here is a small PR with some helper APIs to access IP and Port from ConnRef returned by hackney:connect/1,2,3,4 and also a few cosmetic changes for README. These will help in another project (I am also contributing) where hackney is considered to be used.

Hope you find this PR useful as well.

Thanks!

@c-bik
Copy link
Contributor Author

c-bik commented Apr 27, 2018

Please also feel free to point out if anything in this PR can be improved.

@benoitc
Copy link
Owner

benoitc commented Jun 9, 2018

looking at the PR sorry for the delay, somehow github notifications are broken :/

@benoitc
Copy link
Owner

benoitc commented Jun 9, 2018

changes to the source code are good. However the changes to the readme file should happen in the overview.edoc file since the README is generated from it. Do you want to do the changes, I could take care of it if not. Just le t me know :)

@c-bik
Copy link
Contributor Author

c-bik commented Jun 9, 2018

@benoitc Sorry to miss that overview.edoc bit! I would like to give that a shot over the weekend, if you can wait that long. Otherwise please feel free.

Thanks for your time to this PR 馃憤

@c-bik
Copy link
Contributor Author

c-bik commented Jun 9, 2018

Gave it a try, however, rebar3 edoc is producing a lot of changes all over md! Wasn't sure about them so didn't push!

Please have a look!

Thanked myself too, hope you won't mind 馃槈

@benoitc
Copy link
Owner

benoitc commented Jun 20, 2018

i will check tomorrow. Sorry for the delay!

@benoitc benoitc merged commit d6b0b05 into benoitc:master Sep 1, 2018
@c-bik c-bik deleted the c-bik-ip_port_info_helpers branch September 1, 2018 08:09
benoitc pushed a commit that referenced this pull request Sep 1, 2018
* add sockname and peername methods to the hackney module.

* improve example

* sockname and peername helper info APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants