New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
sockname and peername access from hackney module #504
Conversation
also a few cosmetics to makes examples copy-paste friendly
Please also feel free to point out if anything in this PR can be improved. |
looking at the PR sorry for the delay, somehow github notifications are broken :/ |
changes to the source code are good. However the changes to the readme file should happen in the overview.edoc file since the README is generated from it. Do you want to do the changes, I could take care of it if not. Just le t me know :) |
@benoitc Sorry to miss that overview.edoc bit! I would like to give that a shot over the weekend, if you can wait that long. Otherwise please feel free. Thanks for your time to this PR 馃憤 |
Gave it a try, however, Please have a look! Thanked myself too, hope you won't mind 馃槈 |
i will check tomorrow. Sorry for the delay! |
* add sockname and peername methods to the hackney module. * improve example * sockname and peername helper info APIs
Hi @benoitc,
First off great job 馃憤. This application has more useful features than most other http clients out there (including
httpc
).Here is a small PR with some helper APIs to access IP and Port from
ConnRef
returned byhackney:connect/1,2,3,4
and also a few cosmetic changes for README. These will help in another project (I am also contributing) where hackney is considered to be used.Hope you find this PR useful as well.
Thanks!