Add PSF License Agreement to selectors.py #1226
Merged
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your change. But this licenseshould not been added there but in the NOTICE file and the notice header added here instead. Can you make that change? |
zx-zheng
force-pushed
the
add_psf_license
branch
from
517158a
to
0409c78
Compare
zx-zheng
force-pushed
the
add_psf_license
branch
from
0409c78
to
9f3798a
Compare
|
Thanks for your comment. |
berkerpeksag
added a commit
that referenced
this pull request
Mar 16, 2016
Add PSF License Agreement to selectors.py
|
Thanks! I thought I already did this :) |
|
Attention to detail is so appreciated! Thank you! |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
Add PSF License Agreement to selectors.py
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use gunicorn in production environment. However, I found a license problem which prevent me from using gunicorn in production of my company.
It looks like that selectors.py is the copy of https://github.com/python/cpython/blob/master/Lib/selectors.py.
I think we should add PSF License Agreement to this file according to the license.
https://docs.python.org/2/license.html
https://docs.python.org/3/license.html
Cloud you add license agreement?
Thanks.