Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite recursion when destroying sockets #1219

Merged
merged 1 commit into from Mar 13, 2016

Conversation

tilgovi
Copy link
Collaborator

@tilgovi tilgovi commented Mar 13, 2016

By having a getattr implementation that proxies to the sock
attribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to None.

By having a `getattr` implementation that proxies to the `sock`
attribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to `None`.
@tilgovi tilgovi force-pushed the fix/socket-destroy-recursion branch from dca088d to e46dda7 Compare March 13, 2016 21:50
@benoitc
Copy link
Owner

benoitc commented Mar 13, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants