$FORWARDED_ALLOW_IPS #1205
Merged
$FORWARDED_ALLOW_IPS #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @benoitc |
|
thanks! |
|
@benoitc excellent, thanks! When is the planned-ish date for the next release? |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
$FORWARDED_ALLOW_IPS
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request gives gunicorn the ability to have the
ForwardedAllowIPSsetting (e.g.--forwarded-allow-ips) default configured via the environment variableFORWARDED_ALLOW_IPS. Similar behavior is currently in gunicorn for$WEB_CONCURRENCYand theWorkerssetting.This will allow Heroku users to have a better default Gunicorn configuration out of the box, and will alleviate the need to use ProxyFix middleware in WSGI applications, without effecting their codebase.
✨ 🍰 ✨