Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the --install option instead of sudo. #1072

Merged
merged 1 commit into from Jan 5, 2016
Merged

Use the --install option instead of sudo. #1072

merged 1 commit into from Jan 5, 2016

Conversation

berkerpeksag
Copy link
Collaborator

No description provided.

@tilgovi
Copy link
Collaborator

tilgovi commented Jul 8, 2015

How reliably is the --user install bin going to be in the user's path?

@benoitc
Copy link
Owner

benoitc commented Jul 8, 2015

I have no ideas on what is doing this command, so I will trust you about it :)

@berkerpeksag
Copy link
Collaborator Author

How reliably is the --user install bin going to be in the user's path?

No idea, but it's better than sudo anyway :)

@berkerpeksag
Copy link
Collaborator Author

Actually, we can just remove virtualenv lines.

$ pip install gunicorn
$ cat myapp.py
   def app(environ, start_response):
       data = b"Hello, World!\n"
       start_response("200 OK", [
           ("Content-Type", "text/plain"),
           ("Content-Length", str(len(data)))
       ])
       return iter([data])
$ gunicorn -w 4 myapp:app

looks simpler to me.

@benoitc
Copy link
Owner

benoitc commented Jul 8, 2015

+1

On Wed, Jul 8, 2015 at 7:51 PM Berker Peksag notifications@github.com
wrote:

Actually, we can just remove virtualenv lines.

$ pip install gunicorn
$ cat myapp.py
def app(environ, start_response):
data = b"Hello, World!\n"
start_response("200 OK", [
("Content-Type", "text/plain"),
("Content-Length", str(len(data)))
])
return iter([data])
$ gunicorn -w 4 myapp:app

looks simpler to me.


Reply to this email directly or view it on GitHub
#1072 (comment).

@tilgovi
Copy link
Collaborator

tilgovi commented Jul 8, 2015

Sounds good to me. Virtualenv is the user's choice. We can add a note about virtualenv generally, pointing to a tutorial, if we want to.

@benoitc
Copy link
Owner

benoitc commented Jul 15, 2015

@berkerpeksag so let's go with out sudo then :)

@benoitc
Copy link
Owner

benoitc commented Dec 23, 2015

bump.

@tilgovi
Copy link
Collaborator

tilgovi commented Dec 26, 2015

👍 to removing virtualenv from the instructions.

@berkerpeksag
Copy link
Collaborator Author

I will update this today, thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants