[Fix] no-import-module-exports: Don't crash if packages have no entrypoint
#2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
May 26, 2021
ljharb
force-pushed
the
fix/no-import-module-exports/missing-entrypoint
branch
from
a291621
to
81b9d24
Compare
ljharb
changed the title
ljharb
changed the title
no-import-module-exports: Don't crash if packages have no entrypoint
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getEntryPointassumes every package has one. However, a package does not need to have an entry point e.g. CLI packages such as kcd-scripts.Fixes kentcdodds/kcd-scripts#209