Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] no-restricted-paths: false-positive matches #2090

Merged
merged 1 commit into from May 18, 2021
Merged

[Fix] no-restricted-paths: false-positive matches #2090

merged 1 commit into from May 18, 2021

Conversation

malykhinvi
Copy link
Contributor

@malykhinvi malykhinvi commented May 18, 2021 •
edited

Fixes #2089

In this PR I removed contains-paths dependency and used node's path.relative to identify if a file is inside the target. I used an approach similar to the one used in src/core/importType

@malykhinvi malykhinvi mentioned this pull request May 18, 2021
Closed
@malykhinvi malykhinvi changed the title Reproduce partial paths error [Fix] no-restricted-paths: partial paths false-positive matches May 18, 2021
@coveralls
Copy link

coveralls commented May 18, 2021 •
edited

Coverage Status

Coverage increased (+1.02%) to 82.434% when pulling ddb2132 on malykhinvi:fix-paths into bc99b86 on benmosher:master.

@malykhinvi malykhinvi marked this pull request as ready for review May 18, 2021 13:21
@malykhinvi malykhinvi changed the title [Fix] no-restricted-paths: partial paths false-positive matches [Fix] no-restricted-paths: false-positive matches May 18, 2021
ljharb
ljharb approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great. Normally I firmly believe that more deps is better, but I'm stoked to remove this particular dep.

@ljharb ljharb merged commit ddb2132 into import-js:master May 18, 2021
@RvanderLaan RvanderLaan mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-restricted-path: incorrect zone.target match
3 participants
@malykhinvi @coveralls @ljharb