Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interface declarations for Typescript #1764

Merged

Conversation

julien1619
Copy link
Contributor

Relates to #1528 (comment)

With #1528, in some cases, interface declaration crashed this plugin. This PR fixes it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.739% when pulling 313837b on julien1619:feature/fix-interface-declarations-ts into 92caa35 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.739% when pulling 313837b on julien1619:feature/fix-interface-declarations-ts into 92caa35 on benmosher:master.

@coveralls
Copy link

coveralls commented May 13, 2020

Coverage Status

Coverage remained the same at 97.787% when pulling 40ee069 on julien1619:feature/fix-interface-declarations-ts into eb2b7ea on benmosher:master.

@julien1619 julien1619 force-pushed the feature/fix-interface-declarations-ts branch from 313837b to 949bf8d Compare May 31, 2020 16:07
@julien1619
Copy link
Contributor Author

I rebased it on master, @ljharb can you review it? It's needed to avoid a crash when using Typescript. Thanks!

@ljharb ljharb force-pushed the feature/fix-interface-declarations-ts branch from 949bf8d to 40ee069 Compare May 31, 2020 17:15
@ljharb ljharb merged commit 40ee069 into import-js:master May 31, 2020
@julien1619 julien1619 deleted the feature/fix-interface-declarations-ts branch May 31, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants