New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement alphabetize case insensitive #1586

Merged

ljharb merged 1 commit into import-js:master from dbrewer5:enhancement-alphabetize-case-insensitive

Dec 30, 2019

Contributor

dbrewer5 commented Dec 27, 2019 •

edited by ljharb

Fixes #1581


          [New] order: added caseInsensitive as an additional option to `al…

c28fa7c

…phabetize`

 - imp: mutateRanksToAlphabetizeV2 added to handle case insensitive sorting
 - tests: add two test cases for alphabetize.caseInsensitive: true
 - docs: added documentation for new options: alphabetize.caseInsensitive
 - imp: merged mutateRanksToAlphabetizeV2 to original
 - changelog: updated with caseInsensitive addition

coveralls commented Dec 27, 2019 •

edited

Coverage decreased (-0.05%) to 96.185% when pulling c28fa7c on dbrewer5:enhancement-alphabetize-case-insensitive into 4e8960d on benmosher:master.

coveralls commented Dec 27, 2019

Coverage increased (+0.1%) to 96.352% when pulling ad5e4dc on dbrewer5:enhancement-alphabetize-case-insensitive into 4e8960d on benmosher:master.

4 similar comments

coveralls commented Dec 27, 2019

Coverage increased (+0.1%) to 96.352% when pulling ad5e4dc on dbrewer5:enhancement-alphabetize-case-insensitive into 4e8960d on benmosher:master.

coveralls commented Dec 27, 2019

Coverage increased (+0.1%) to 96.352% when pulling ad5e4dc on dbrewer5:enhancement-alphabetize-case-insensitive into 4e8960d on benmosher:master.

coveralls commented Dec 27, 2019

Coverage increased (+0.1%) to 96.352% when pulling ad5e4dc on dbrewer5:enhancement-alphabetize-case-insensitive into 4e8960d on benmosher:master.

coveralls commented Dec 27, 2019

Coverage increased (+0.1%) to 96.352% when pulling ad5e4dc on dbrewer5:enhancement-alphabetize-case-insensitive into 4e8960d on benmosher:master.

ljharb reviewed

View reviewed changes

Member

ljharb left a comment

Just the one comment left.

docs/rules/order.md

@@ @@ -210,12 +212,14 @@ import React, { PureComponent } from 'react'; @@
               import aTypes from 'prop-types';
               import { compose, apply } from 'xcompose';
               import * as classnames from 'classnames';
+              import blist from 'BList';

Member

ljharb Dec 30, 2019

perhaps a relative path would be better here, since npm package names can't be capitalized (for many years now)

src/rules/order.js Outdated Show resolved Hide resolved

ljharb force-pushed the enhancement-alphabetize-case-insensitive branch from ad5e4dc to c53a069 Compare

December 30, 2019 22:09

ljharb added the semver-minor label

ljharb approved these changes

View reviewed changes

Member

ljharb left a comment

Actually let's just leave this as-is.

ljharb force-pushed the enhancement-alphabetize-case-insensitive branch from c53a069 to c28fa7c Compare

December 30, 2019 22:11

ljharb merged commit c28fa7c into import-js:master

timiles mentioned this pull request

Case-insensitive ordering trivago/prettier-plugin-sort-imports#68

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment