Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extensions] Ignore query strings when checking for extensions. #1572

Merged
merged 1 commit into from Jan 1, 2020

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Dec 15, 2019

Fixes #1567.

@coveralls
Copy link

coveralls commented Dec 15, 2019

Coverage Status

Coverage decreased (-0.1%) to 96.176% when pulling 982493d on pcorpet:query-string-extension into b791ba5 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 96.367% when pulling e3fa2ce on pcorpet:query-string-extension into 4e8960d on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

src/rules/extensions.js Outdated Show resolved Hide resolved
src/rules/extensions.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[extensions] Alerting on missing extension when using query string
3 participants