[patch] use `resolve` instead of `builtin-modules` #1069

ljharb · 2018-04-07T20:36:03Z

resolve has a much more thorough list of builtins, and since I maintain it, we can keep it updated more easily than with builtin-modules.

ljharb · 2018-04-07T20:37:17Z

Absent objections, I'm going to merge this once tests pass.

coveralls · 2018-04-07T20:48:19Z

Coverage remained the same at 96.47% when pulling fb8e1e5 on ljharb:resolve into d8077c8 on benmosher:master.

ljharb · 2018-04-07T21:27:00Z

appveyor failure is a fluke.

benmosher

makes sense to me 👍

[patch] use resolve instead of builtin-modules

fb8e1e5

ljharb requested review from benmosher and jfmengels April 7, 2018 20:36

ljharb merged commit f0b4f3e into import-js:master Apr 7, 2018

ljharb deleted the resolve branch April 7, 2018 21:27

benmosher reviewed Apr 9, 2018

View reviewed changes

This was referenced Apr 12, 2018

Update eslint-plugin-import to 2.12.0 sbardian/DebtTrackerAPI#25

Merged

Update dependency eslint-plugin-import to v2.11.0 Urigo/tortilla#68

Merged

ljharb mentioned this pull request Feb 27, 2019

fix a bunch of tests that were failing #1295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[patch] use `resolve` instead of `builtin-modules` #1069

[patch] use `resolve` instead of `builtin-modules` #1069

ljharb commented Apr 7, 2018

ljharb commented Apr 7, 2018

coveralls commented Apr 7, 2018 •

edited

ljharb commented Apr 7, 2018

benmosher left a comment

[patch] use resolve instead of builtin-modules #1069

[patch] use resolve instead of builtin-modules #1069

Conversation

ljharb commented Apr 7, 2018

ljharb commented Apr 7, 2018

coveralls commented Apr 7, 2018 • edited

ljharb commented Apr 7, 2018

benmosher left a comment

Choose a reason for hiding this comment

[patch] use `resolve` instead of `builtin-modules` #1069

[patch] use `resolve` instead of `builtin-modules` #1069

coveralls commented Apr 7, 2018 •

edited