Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-cycle: create must *always* return an object, even if no listeners #1064

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Apr 5, 2018

This is breaking eslint-plugin-airbnb's tests, and will break on any linting that's done on piped-in text.

cc @sharmilajesupaul @not-an-aardvark

@ljharb ljharb requested a review from benmosher April 5, 2018 17:02
@coveralls
Copy link

coveralls commented Apr 5, 2018

Coverage Status

Coverage remained the same at 96.47% when pulling 19fc3df on ljharb:fix_no_cycle into ee15fa4 on benmosher:master.

Copy link
Member

@benmosher benmosher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a handful of other return cases in this rule; do those need to be returning objects as well? I am unfamiliar with this requirement.

@ljharb
Copy link
Member Author

ljharb commented Apr 6, 2018

The other cases are inside a nested function; there’s only 2 returns inside create.

Copy link
Member

@benmosher benmosher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhhhh right. gosh, it really has been forever since I've done anything with this, I totally forgot that create is returning a object of node visitors. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants