Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type errors with TypeScript 5.4+ #948

Open
freben opened this issue Apr 17, 2024 · 0 comments · May be fixed by #950
Open

Type errors with TypeScript 5.4+ #948

freben opened this issue Apr 17, 2024 · 0 comments · May be fixed by #950

Comments

@freben
Copy link

freben commented Apr 17, 2024

When upgrading to TypeScript 5.4+, importing from ast-types leads to type errors.

Reproduction:

Result:
image

Obeying the instructions and explicitly making them type imports solves the problem:

-import { ASTNode, Type, AnyType, Field } from "./lib/types";
+import { ASTNode, type Type, AnyType, Field } from "./lib/types";
-import { NodePath } from "./lib/node-path";
+import { type NodePath } from "./lib/node-path";
-import { builders } from "./gen/builders";
+import { type builders } from "./gen/builders";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant