Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install fails due to conflicting peer dependency #768

Open
andersk opened this issue May 25, 2022 · 0 comments · May be fixed by #769
Open

npm install fails due to conflicting peer dependency #768

andersk opened this issue May 25, 2022 · 0 comments · May be fixed by #769

Comments

@andersk
Copy link
Contributor

andersk commented May 25, 2022

ts-emit-clean has a peer dependency on typescript@^3.0.0 that conflicts with our devDependency on typescript@4.5.2. This breaks npm install.

$ git clone https://github.com/benjamn/ast-types.git

$ cd ast-types

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: ts-emit-clean@1.0.0
npm ERR! Found: typescript@4.5.2
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"4.5.2" from the root project
npm ERR!   peer typescript@">=2.7" from ts-node@10.4.0
npm ERR!   node_modules/ts-node
npm ERR!     dev ts-node@"10.4.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^3.0.0" from ts-emit-clean@1.0.0
npm ERR! node_modules/ts-emit-clean
npm ERR!   dev ts-emit-clean@"1.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: typescript@3.9.10
npm ERR! node_modules/typescript
npm ERR!   peer typescript@"^3.0.0" from ts-emit-clean@1.0.0
npm ERR!   node_modules/ts-emit-clean
npm ERR!     dev ts-emit-clean@"1.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/anders/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/anders/.npm/_logs/2022-05-25T21_45_28_938Z-debug-0.log

$ node --version
v16.15.0

$ npm --version
8.10.0

(Also affects recast. I won’t bother filing a separate issue unless you want one.)

andersk added a commit to andersk/ast-types that referenced this issue May 25, 2022
Fixes benjamn#768.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk linked a pull request May 25, 2022 that will close this issue
andersk added a commit to andersk/ast-types that referenced this issue May 25, 2022
Fixes benjamn#768.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/recast that referenced this issue May 25, 2022
See benjamn/ast-types#768.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/recast that referenced this issue May 25, 2022
See benjamn/ast-types#768.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
coderaiser pushed a commit to coderaiser/recast that referenced this issue May 27, 2022
See benjamn/ast-types#768.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant