Add support for PEP 560 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
reviewed
Nov 2, 2019
| @@ -16,7 +16,7 @@ install: | |||
| - pip install --upgrade --force-reinstall "setuptools; python_version != '3.2' and python_version != '3.3'" "setuptools < 30; python_version == '3.2'" "setuptools < 40; python_version == '3.3'" | |||
| - pip uninstall --yes six || true | |||
| - pip install --upgrade --force-reinstall --ignore-installed -e . | |||
| - pip install pytest | |||
| - pip install pytest typing | |||
There was a problem hiding this comment.
Is it possible to test this without depending on typing?
There was a problem hiding this comment.
Sure, this was just the simplest way. I thought it is OK to add it here since typing will not be a dependency for six itself. Do you want me to add an extra test, or replace the existing one? (I would prefer to keep the existing one.)
There was a problem hiding this comment.
(FWIW I added a typing-agnostic test.)
There was a problem hiding this comment.
Yes, I mainly wanted to make sure that the semantic change was tested directly rather than relying on typing.
benjaminp
approved these changes
Nov 5, 2019
| @@ -16,7 +16,7 @@ install: | |||
| - pip install --upgrade --force-reinstall "setuptools; python_version != '3.2' and python_version != '3.3'" "setuptools < 30; python_version == '3.2'" "setuptools < 40; python_version == '3.3'" | |||
| - pip uninstall --yes six || true | |||
| - pip install --upgrade --force-reinstall --ignore-installed -e . | |||
| - pip install pytest | |||
| - pip install pytest typing | |||
There was a problem hiding this comment.
Yes, I mainly wanted to make sure that the semantic change was tested directly rather than relying on typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly important for
typingmodule that is extensively using PEP 560 since Python 3.7. The goal of this PR is to makebehave equivalently to
and
on all Python versions (also with custom metaclasses on Python versions where it is supported).