Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deploy to another repository #112

Merged
merged 77 commits into from
May 28, 2022
Merged

Implement deploy to another repository #112

merged 77 commits into from
May 28, 2022

Conversation

ktbarrett
Copy link
Contributor

Rebase of #37. Closes #36. Closes #61. Closes #87.

I don't know typescript, so feel free to take it and run with it.

src/git.ts Outdated Show resolved Hide resolved
Co-authored-by: Marlon James <marlon.james@gmail.com>
@ktbarrett
Copy link
Contributor Author

@ktrz

@ktrz
Copy link
Member

ktrz commented Mar 4, 2022

Thank you @ktbarrett for updating the previous PR. I'll have a look over the weekend

Copy link
Member

@ktrz ktrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PR. I've added a couple of comments to improve it and also asked a couple of questions.

Additionally, could you add some additional unit tests that would verify this new logic is working as intended?

src/write.ts Outdated Show resolved Hide resolved
src/write.ts Outdated Show resolved Hide resolved
src/write.ts Outdated Show resolved Hide resolved
src/write.ts Outdated Show resolved Hide resolved
src/write.ts Outdated Show resolved Hide resolved
src/write.ts Show resolved Hide resolved
src/git.ts Outdated Show resolved Hide resolved
@Trashtalk217
Copy link

Hello, I would very much like to use this feature, because I have a private branch that can't have Github pages. Is there a way I can help?

@ktbarrett
Copy link
Contributor Author

ktbarrett commented Mar 21, 2022

@Trashtalk217 I'm sure the maintainers don't want a litter of PRs in this repo. You can make the fixes in your fork and can open a PR against this PR's branch in my fork, and it will update this PR. I'm not familiar with typescript and I'm a little busy to learn, so any help is appreciated!

@ktrz
Copy link
Member

ktrz commented Mar 27, 2022

FYI: I'm picking it up to get it to the finish line

@ktrz
Copy link
Member

ktrz commented May 19, 2022

I finally got the CI working and verified that using a separate repository works. I need to clean up the code and add additional workflows to push changes to a separate repo I've created to show as an example

@ktrz ktrz merged commit 0e77d47 into benchmark-action:master May 28, 2022
@ktrz
Copy link
Member

ktrz commented May 28, 2022

thank you @ktbarrett for helping with this feature!
released in v1.14.0

@ktbarrett ktbarrett deleted the push-other-repo branch May 28, 2022 20:10
@ktbarrett
Copy link
Contributor Author

@ktrz And thank you for pushing this through. Seemed like there was more problem than anticipated. We appreciate all your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants