Regression in latest 1.2.1 version

[alambike]

Bug description

We see strange behavior in our workflows, after upgrading to the latest 1.2.1 version.

After this change, now if the passed ref is an empty string, the action is not calculating the ref and the step fails.

Example:

      - name: Dispatch my-workflow with workflow_dispatch
        if: github.event_name == 'workflow_dispatch' || github.event.pull_request.merged == true
        uses: benc-uk/workflow-dispatch@b8ac4001bdf17685419a1b65af6fa92fc9a3de0e
        with:
          workflow: my-workflow
          ref: ${{ github.head_ref }}

In the case when a workflow_dispatch event triggers this workflow, the github.head_ref is empty, but now the action doesn't calculate the github.ref, as a ref input is passed, so the ref ends up as an empty string and the workflow execution fails with:

Error: No ref found for:

[benc-uk]

Hmmm interesting, maybe a good reason it was the way it was before!
I'll release a fix

[benc-uk]

Should be fixed in master, v1, v1.2 and v1.2.2
Let me know if its not

[dpelengic]

Observing this issue in v1, after the update.

[dfar-io]

Still seeing the issue in both v1 and v1.2.2, going to try adding ref and see if that works as a fix:

Definition:

- name: Trigger Deployment
        uses: benc-uk/workflow-dispatch@v1
        with:
          workflow: Deploy
          token: ${{ secrets.GIT_TOKEN }}
          inputs: '{ "message": "${{ env.COMMIT_MESSAGE }}" }'

[bjoernw]

Still breaking even at benc-uk/workflow-dispatch@a69ac85ea87587e76bb4f262eb868205dfcab8e8

[dfar-io]

A workaround for the time being, adding ref:

- name: Trigger Deployment
        uses: benc-uk/workflow-dispatch@v1.2.2
        with:
          workflow: YOUR_WORKFLOW
          ref: ${{ github.event.ref }}
          inputs: ANY_INPUTS_YOU_MIGHT_HAVE

[bjoernw]

Can confirm, workaround works. Going to leave this pinned to a git sha ;)

uses: benc-uk/workflow-dispatch@a69ac85ea87587e76bb4f262eb868205dfcab8e8
with:
   workflow: my-workflow
   ref: ${{ github.event.ref }}

[whanata]

A workaround for the time being, adding ref:

- name: Trigger Deployment
        uses: benc-uk/workflow-dispatch@v1.2.2
        with:
          workflow: YOUR_WORKFLOW
          ref: ${{ github.event.ref }}
          inputs: ANY_INPUTS_YOU_MIGHT_HAVE

It doesn't work if I use a schedule though, I still get the same error.

[benc-uk]

Realize there was a release tagging issue
Can people try again with v1 or v1.2 or v1.2.2 tags?

[whanata]

Cheers, it looks like it's working for me now, thanks.

[benc-uk]

Closing for now as it seems to be fixed