Dependency formatting output, new lines included? #822
Comments
|
I'm not sure what you mean. I tried and did not observe any problems. Do you mean the xml format's indent (#818) or maybe the Gradle / Android xml incompatibility (gradle/gradle#26672)? remote: Enumerating objects: 11581, done.
remote: Counting objects: 100% (780/780), done.
remote: Compressing objects: 100% (343/343), done.
remote: Total 11581 (delta 382), reused 666 (delta 295), pack-reused 10801
Receiving objects: 100% (11581/11581), 2.04 MiB | 3.27 MiB/s, done.
Resolving deltas: 100% (4992/4992), done.
➜ projects cd android-gif-search
➜ android-gif-search git:(master) gradlew dependencyUpdates
zsh: command not found: gradlew
➜ android-gif-search git:(master) ./gradlew dependencyUpdates
Downloading https://services.gradle.org/distributions/gradle-8.1.1-bin.zip
...........10%............20%............30%............40%............50%............60%............70%............80%...........90%............100%
Welcome to Gradle 8.1.1!
Here are the highlights of this release:
- Stable configuration cache
- Experimental Kotlin DSL assignment syntax
- Building with Java 20
For more details see https://docs.gradle.org/8.1.1/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Configure project :test-shared
w: file:///Users/ben/projects/android-gif-search/test-shared/build.gradle.kts:66:11: 'constructor URL(String!)' is deprecated. Deprecated in Java
> Task :dependencyUpdates
------------------------------------------------------------
: Project Dependency Updates (report to plain text file)
------------------------------------------------------------
The following dependencies are using the latest milestone version:
- androidx.appcompat:appcompat:1.6.1
- androidx.startup:startup-runtime:1.1.1
- androidx.test:annotation:1.0.1
- androidx.test:core:1.5.0
- androidx.test:orchestrator:1.4.2
- androidx.test:rules:1.5.0
- androidx.test:runner:1.5.2
- androidx.test.ext:junit:1.1.5
- com.getkeepsafe.dexcount:com.getkeepsafe.dexcount.gradle.plugin:4.0.0
- com.github.bumptech.glide:glide:4.16.0
- com.github.bumptech.glide:ksp:4.16.0
- com.github.bumptech.glide:okhttp3-integration:4.16.0
- com.google.accompanist:accompanist-drawablepainter:0.32.0
- com.google.accompanist:accompanist-swiperefresh:0.32.0
- com.google.accompanist:accompanist-webview:0.32.0
- com.google.android.material:material:1.9.0
- com.google.code.findbugs:jsr305:3.0.2
- com.google.dagger:hilt-android:2.46.1
- com.google.dagger:hilt-android-compiler:2.46.1
- com.google.dagger:hilt-android-testing:2.46.1
- com.google.dagger:hilt-compiler:2.46.1
- com.jakewharton.timber:timber:5.0.1
- com.jaredsburrows.license:com.jaredsburrows.license.gradle.plugin:0.9.3
- com.nhaarman.mockitokotlin2:mockito-kotlin:2.2.0
- com.squareup.leakcanary:leakcanary-android-instrumentation:2.12
- com.squareup.leakcanary:leakcanary-android-startup:2.12
- com.squareup.moshi:moshi:1.15.0
- com.squareup.moshi:moshi-adapters:1.15.0
- com.squareup.moshi:moshi-kotlin-codegen:1.15.0
- com.squareup.okhttp3:logging-interceptor:4.12.0
- com.squareup.okhttp3:mockwebserver:4.12.0
- com.squareup.okhttp3:okhttp:4.12.0
- com.squareup.okhttp3:okhttp-bom:4.12.0
- com.squareup.retrofit2:converter-moshi:2.9.0
- com.squareup.retrofit2:retrofit:2.9.0
- junit:junit:4.13.2
- org.glassfish:javax.annotation:10.0-b28
- org.jetbrains.kotlin:kotlin-bom:1.8.22
- org.jetbrains.kotlin:kotlin-compiler-embeddable:1.8.22
- org.jetbrains.kotlin:kotlin-klib-commonizer-embeddable:1.8.22
- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.22
- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3
- org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.7.3
- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3
- org.jetbrains.kotlinx:kotlinx-coroutines-jdk8:1.7.3
- org.jetbrains.kotlinx:kotlinx-coroutines-test:1.7.3
- org.mockito:mockito-inline:5.2.0
The following dependencies have later milestone versions:
- androidx.activity:activity-compose [1.7.2 -> 1.8.2]
https://developer.android.com/jetpack/androidx/releases/activity#1.7.2
- androidx.activity:activity-ktx [1.7.2 -> 1.8.2]
https://developer.android.com/jetpack/androidx/releases/activity#1.7.2
- androidx.annotation:annotation [1.6.0 -> 1.7.1]
https://developer.android.com/jetpack/androidx/releases/annotation#1.7.1
- androidx.compose:compose-bom [2023.06.00 -> 2023.10.01]
https://developer.android.com/jetpack
- androidx.compose.compiler:compiler [1.4.7 -> 1.5.7]
https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.4.7
- androidx.compose.material:material [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-material#1.5.4
- androidx.compose.material3:material3 [1.1.0 -> 1.1.2]
https://developer.android.com/jetpack/androidx/releases/compose-material3#1.1.2
- androidx.compose.runtime:runtime [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.5.4
- androidx.compose.ui:ui [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-ui#1.5.4
- androidx.compose.ui:ui-test-junit4 [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-ui#1.5.4
- androidx.compose.ui:ui-test-manifest [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-ui#1.5.4
- androidx.compose.ui:ui-tooling [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-ui#1.5.4
- androidx.compose.ui:ui-tooling-preview [1.4.3 -> 1.5.4]
https://developer.android.com/jetpack/androidx/releases/compose-ui#1.5.4
- androidx.core:core-ktx [1.10.1 -> 1.12.0]
https://developer.android.com/jetpack/androidx/releases/core#1.12.0
- androidx.hilt:hilt-navigation-compose [1.0.0 -> 1.1.0]
https://developer.android.com/jetpack/androidx/releases/hilt#1.1.0
- androidx.lifecycle:lifecycle-viewmodel-ktx [2.6.1 -> 2.6.2]
https://developer.android.com/jetpack/androidx/releases/lifecycle#2.6.2
- androidx.navigation:navigation-compose [2.6.0 -> 2.7.6]
https://developer.android.com/jetpack/androidx/releases/navigation#2.6.0
- androidx.webkit:webkit [1.7.0 -> 1.9.0]
https://developer.android.com/jetpack/androidx/releases/webkit#1.7.0
- com.android.application:com.android.application.gradle.plugin [8.0.0-rc01 -> 8.3.0-alpha18]
https://developer.android.com/studio/build
- com.android.library:com.android.library.gradle.plugin [8.0.0-rc01 -> 8.3.0-alpha18]
https://developer.android.com/studio/build
- com.android.tools:desugar_jdk_libs [2.0.3 -> 2.0.4]
https://github.com/google/desugar_jdk_libs
- com.github.ben-manes.versions:com.github.ben-manes.versions.gradle.plugin [0.49.0 -> 0.50.0]
- com.github.skydoves:landscapist-animation [2.2.12 -> 2.2.13]
https://github.com/skydoves/landscapist
- com.github.skydoves:landscapist-glide [2.2.12 -> 2.2.13]
https://github.com/skydoves/landscapist
- com.github.skydoves:landscapist-palette [2.2.12 -> 2.2.13]
https://github.com/skydoves/landscapist
- com.github.triplet.play:com.github.triplet.play.gradle.plugin [3.8.4 -> 3.8.6]
- com.google.dagger.hilt.android:com.google.dagger.hilt.android.gradle.plugin [2.46.1 -> 2.50]
https://github.com/google/dagger
- com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin [1.8.22-1.0.11 -> 1.9.21-1.0.16]
https://goo.gle/ksp
- com.google.devtools.ksp:symbol-processing [1.8.22-1.0.11 -> 1.9.21-1.0.16]
https://goo.gle/ksp
- com.google.devtools.ksp:symbol-processing-api [1.8.22-1.0.11 -> 1.9.21-1.0.16]
https://goo.gle/ksp
- com.google.devtools.ksp:symbol-processing-cmdline [1.8.22-1.0.11 -> 1.9.21-1.0.16]
https://goo.gle/ksp
- com.google.truth:truth [1.1.5 -> 1.2.0]
http://github.com/google/truth
- com.pinterest:ktlint [0.47.1 -> 0.51.0-FINAL]
https://github.com/pinterest/ktlint
- com.pinterest.ktlint:ktlint-reporter-baseline [0.47.1 -> 0.51.0-FINAL]
https://github.com/pinterest/ktlint
- com.pinterest.ktlint:ktlint-ruleset-standard [0.47.1 -> 1.1.0]
https://github.com/pinterest/ktlint
- com.squareup.okio:okio [3.6.0 -> 3.7.0]
https://github.com/square/okio/
- javax.annotation:jsr250-api [1.0 -> 1.0-20050927.133100]
https://jax-ws.dev.java.net/
- org.jetbrains.kotlin.android:org.jetbrains.kotlin.android.gradle.plugin [1.8.22 -> 1.9.21]
https://kotlinlang.org/
- org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin [1.8.22 -> 1.9.21]
https://kotlinlang.org/
- org.jlleitschuh.gradle.ktlint:org.jlleitschuh.gradle.ktlint.gradle.plugin [11.6.1 -> 12.0.3]
- org.robolectric:annotations [4.10.3 -> 4.11.1]
http://robolectric.org
- org.robolectric:robolectric [4.10.3 -> 4.11.1]
http://robolectric.org
Gradle release-candidate updates:
- Gradle: [8.1.1 -> 8.5]
Generated report file build/dependencyUpdates/report.txt
BUILD SUCCESSFUL in 4m 26s
1 actionable task: 1 executed
Publishing build scan...
https://gradle.com/s/36lrnlqnshmuc |
|
To help, I am trying to upgrade Gradle from 8.1.1 to 8.5. Using Gradle 8.1.1 and Versions plugin 0.49.0, it works fine:With Gradle 8.5, it fails: |
|
I think that is a Gradle bug. There's a random thread attached to an existing, unrelated issue where someone ran into that recently. It looked like a problem with a corrupt dependency graph and something you'd need to get the Gradle teams help on.
|
|
I think you are right. I was able to reproduce it for a while. I ended up reverting the changes and upgraded gradle, android gradle plugin and the versions plugin individually. Gradle - 8.5 This passes now: But is this a concern?Should it be? |
|
I suppose we should trim it before printing, for whatever reason. For me I got that binary error as you described and then applied the gradle.properties xml overrides and it went away. Maybe they are hitting their own SAX security exception, since the older Android plugins bring in an incompatible xml library (xerces). I didn't get that - com.google.dagger:hilt-android [2.46.1 -> 2.50]
https://github.com/google/dagger
- com.google.dagger:hilt-android-testing [2.46.1 -> 2.50]
https://github.com/google/dagger |
|
I ran with |
|
I had those gradle properties set and reverted it, maybe the daemon remembered them. Can you add that workaround? |
|
Sorry, which gradle properties? My home |
|
Gradle 8.4 is incompatible with xml dependencies and breaks things randomly. I found a workaround, gradle/gradle#26672, so you can add this to your props and it will force the JDK's to be used. systemProp.javax.xml.parsers.SAXParserFactory=com.sun.org.apache.xerces.internal.jaxp.SAXParserFactoryImpl
systemProp.javax.xml.transform.TransformerFactory=com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl
systemProp.javax.xml.parsers.DocumentBuilderFactory=com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl |
|
@ben-manes Thanks. That does work. For this issue, we want to change the output of those versions being on new lines or close this? |
|
I think we can close and, if worth the brain cells, you're welcome to open a new one so we can avoid this noise. I agree it would look nicer to fix that styling but I think most users are focused on the error so making it prettier isn't really a concern for them 😄 |
|
Same issue in my Android project:
Once, I add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like there are new lines brought in or added to some dependencies
Repro:
Example output:
Based on https://repo1.maven.org/maven2/com/google/dagger/hilt-android/2.46.1/, you can view the POM file here: https://repo1.maven.org/maven2/com/google/dagger/hilt-android/2.46.1/hilt-android-2.46.1.pom.
There is no new lines or white space:
The text was updated successfully, but these errors were encountered: