Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jacoco versions erroneously shown as exceeding the milestone revision level #813

Open
msridhar opened this issue Sep 18, 2023 · 3 comments

Comments

@msridhar
Copy link

Running ./gradlew dependencyUpdates --refresh-dependencies on uber/NullAway@70af259 (current master branch) I see this in the output:

The following dependencies exceed the version found at the milestone revision level:
 - org.jacoco:org.jacoco.agent [0.8.10 <- 0.8.9]
     http://jacoco.org
 - org.jacoco:org.jacoco.ant [0.8.10 <- 0.8.9]
     http://jacoco.org

But I can see version 0.8.10 of those artifacts on Maven Central (released a few months back). Nothing critical at all for us, just in case it is of interest.

@ben-manes
Copy link
Owner

hmm, it is reported correctly in Caffeine

The following dependencies are using the latest milestone version:
....
 - org.jacoco:org.jacoco.agent:0.8.10
 - org.jacoco:org.jacoco.ant:0.8.10

@ben-manes
Copy link
Owner

This seems to be the regression reported in #733 where hidden dependencies are not being treated properly. When I use the prior version, 0.45.0, the report comes out correctly. It should generally be hidden as a tool version that users won't typically understand where it comes from. When it was, in Caffeine I would add those to a dummy configuration to see the update as an opt-in. I'm unsure if reverting the contribution is the right approach, or if it requires digging deeply into its intent and fixing both issues correctly. The gradle dependency resolution behavior gets kind of confusing and it's hard to get motivated enough to fight through it...

@msridhar
Copy link
Author

Thanks for looking into it! Not a huge deal for us. Feel free to close if this is a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants