Ability to use failOnNonReproducibleResolution with the plugin?

[boris-petrov]

I wanted to add the following to my build.gradle file:

configurations.all {
	resolutionStrategy {
		failOnNonReproducibleResolution()
	}
}

Just to have more "safety" with dependencies. However, that seems to break the versions-plugin with a message that dynamic-versions are disabled (as failOnNonReproducibleResolution includes failOnDynamicVersions). Any suggestions on how can I make the plugin work and have this setting enabled?

[ben-manes]

In #592

Usually you can get around this by conditionalizing the your resolution strategy to no-op if the dependencyUpdate task will be run. The simplest is checking for it ingradle.startParameter.taskNames, with a fancier version being to use gradle.taskGraph.whenReady. I think the latter might not work since Gradle 7.0 as I recall them making things stricter.

[ben-manes]

Also looks like there is a workaround in #593, maybe not yet released?

[boris-petrov]

Ah, sorry, I searched for failOnNonReproducibleResolution before opening the issue, should have also searched for failOnDynamicVersions!

That PR sounds like it resolves the issue, yes. But it's not released, no. Perhaps you can do that? 😄

Thanks for the prompt response!

[ben-manes]

If you'd like, you can send a PR that follows a similar pattern to disable failOnNonReproducibleResolution and then we could trigger a release afterwards?

[boris-petrov]

I'm not sure that's needed for failOnNonReproducibleResolution. If I understand correctly from Gradle's documentation (the two links I sent above) - failOnNonReproducibleResolution just enables failOnDynamicVersions and failOnChangingVersions. The former is already fixed. I'm not sure if the latter would break gradle-versions-plugin? My tests show it doesn't seem so. So perhaps no change from master is needed?

[ben-manes]

oh then that's good, I am not familiar with that option

[boris-petrov]

Yeah, we can try - if you release a new version, I'll try it with failOnNonReproducibleResolution and failOnDynamicVersions. If it works, great. If the former doesn't work, I'll submit a PR and you can release a second version. 😄

[ben-manes]

You could install the plugin locally and use mavenLocal() in your project.

Otherwise, I am reviewing how a release is performed with the build and rewrite to kotlin since I am not familiar with the process anymore.

[boris-petrov]

Sure, no worries! I'll see how this local installation works and I'll write here in a few hours with the results. Thanks!

[ben-manes]

easy peasy, released!

/cc @jaredsburrows

[boris-petrov]

Great, thanks! I confirm that the new version fixes the issue with failOnNonReproducibleResolution!

[ben-manes]

wonderful, thanks @boris-petrov and @keykey7! 😃