Prevent builds from failing w/ configuration cache enabled on Gradle 7.4+ #585
Conversation
| private void callIncompatibleWithConfigurationCache() { | ||
| String methodName = "notCompatibleWithConfigurationCache" | ||
| Object[] methodArgs = ["The gradle-versions-plugin isn't compatible with the configuration cache"] | ||
| metaClass.invokeMethod(this, methodName, methodArgs) |
There was a problem hiding this comment.
I think you can simply invoke the method since it is dynamically typed? Our other usages only guard before making the method call directly.
There was a problem hiding this comment.
I'm not the most well versed on Groovy because that's what I thought as well, but the IDE was showing it as red. I didn't actually try running it though.
There was a problem hiding this comment.
haha, me neither. I just use VSCode and pray =)
There was a problem hiding this comment.
I just double checked and it won't run. I'm assuming the compiler can't see it because the version of the Gradle API needs to be bumped, but not sure if that is desired at the moment.
There was a problem hiding this comment.
Sounds good, thanks! (Let's keep your code as is)
|
You are welcome to merge and make a release. To do that simply increment the build's version, create the release (it will create a tag), and the github action will publish it to the portal. |
eygraber
force-pushed
the
dont-fail-w-configuration-cache
branch
from
cf74039
to
2e75446
Compare
No description provided.