Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not detect kotlin-wrappers #442

Closed
mustafaozhan opened this issue Nov 5, 2020 · 8 comments
Closed

Can not detect kotlin-wrappers #442

mustafaozhan opened this issue Nov 5, 2020 · 8 comments

Comments

@mustafaozhan
Copy link

They are mostly used in Kotlin Multi Platform apps and the plugin can not detect them.
Maybe it is because they have weird version number like 17.0.0-pre.126-kotlin-1.4.10 please refere here for more detail.

Failed to determine the latest version for the following dependencies (use --info for details):
 - org.jetbrains:kotlin-react
 - org.jetbrains:kotlin-react-dom
 - org.jetbrains.kotlinx:kotlinx-html-js
@ben-manes
Copy link
Owner

I this with 0.34? If not, please try that version which contains a fix for multi-platform resolution

@mustafaozhan
Copy link
Author

Yes exactly, I tried with latest (0.34.0)

@ben-manes
Copy link
Owner

hmm, we would need a sample project to debug with then.

@mustafaozhan
Copy link
Author

mustafaozhan commented Nov 5, 2020

You can clone this repo. Note that repo has version 0.33.0 currently please update it to 0.34.0.
buildSrc>src>main>kotlin>Configs.kt>Versions

    const val versionChecker = "0.33.0" // this is the version for plugin

Note: You will need latest (Canary) version of Android Studio to open it

@ben-manes
Copy link
Owner

It does seem to be the same error that was fixed in 0.34, so not sure why it still occurs for you.

I'll try to take a deeper look later, but not sure when I'll find the time.

@mustafaozhan
Copy link
Author

Yeap sure thank you :) just wanted to report it

@ben-manes
Copy link
Owner

In your case commonMainMetadataElements wasn't available to the JS project, so we couldn't capture the attributes. The compile configuration does exist and contain it, so used a restrictive fallback to copy those kotlin attributes if found. This seems to pass in your project, non-kotlin projects, and the projects from prior MPP issues.

@mustafaozhan
Copy link
Author

Thanks a lot! I confirm that it is fixed with 0.35.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants