Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html report #418

Merged
merged 4 commits into from Sep 4, 2020
Merged

html report #418

merged 4 commits into from Sep 4, 2020

Conversation

jcrokicki
Copy link
Collaborator

No description provided.

@ben-manes
Copy link
Owner

This looks pretty great, just some minor comments to consider. I sent you commit access to merge when you're ready.

You can even release this yourself :)

  1. Increment the version in build.gradle and commit
  2. Add Github release notes (creates a new tag)
  3. CI will see the new tag and deploy the archive.
  4. It takes a few hours for JCenter to sync with Gradle's plugin repository

@ben-manes
Copy link
Owner

Tried the new commit, pretty cool! :)

I sent you an invite to have commit access. When you're happy, feel free to merge.

@jcrokicki
Copy link
Collaborator Author

crap. ok, need to know how Caffeine may use it. There is some logic in the second commit that chooses where to get the version and it differs from how the plain text report does it. I couldnt get the same syntax to work from there (eg. available[revision])

@ben-manes
Copy link
Owner

sorry, should have commented on the prior convo, moved it up there for resolution.

@jcrokicki
Copy link
Collaborator Author

sorry, should have commented on the prior convo, moved it up there for resolution.

supporting and tested with the three defined revision values - release, milestone, and integration.

This was referenced Sep 4, 2020
@ben-manes
Copy link
Owner

Verified on Caffeine, looks great!

@jcrokicki jcrokicki merged commit ce34c21 into ben-manes:master Sep 4, 2020
@jcrokicki jcrokicki deleted the html-report branch September 4, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants