Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter invalid event in object store trace #814

Merged
merged 1 commit into from Nov 8, 2022

Conversation

guykhazma
Copy link
Contributor

@guykhazma guykhazma commented Nov 8, 2022

The object store trace contains some range reads events with invalid ending offset resulting in events with negative weight.
For example, the following events in IBMObjectStoreTrace001Part0:

192199064 REST.GET.OBJECT 6c44b4d75e985008 0 0 -1
192199064 REST.GET.OBJECT fb7caa17fb475a5c 0 0 -1
192200755 REST.GET.OBJECT 12c21c4f26736f15 0 0 -1
192200755 REST.GET.OBJECT a8a514e89f0ff7aa 0 0 -1

This PR filters these events as part of the reader to avoid pre-processing the input file

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022

CLA assistant check
All committers have signed the CLA.

@ben-manes ben-manes merged commit a29ac99 into ben-manes:master Nov 8, 2022
@ben-manes
Copy link
Owner

nice find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants