Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for options in a config file. #43

Closed
belav opened this issue Mar 24, 2021 · 2 comments
Closed

Support for options in a config file. #43

belav opened this issue Mar 24, 2021 · 2 comments
Labels
duplicate This issue or pull request already exists type:enhancement New feature or request

Comments

@belav
Copy link
Owner

belav commented Mar 24, 2021

When there are options available for formatting - #10 - it should be possible to specify those options in a config file. That will ensure that if csharpier is run via command line, build task, or some other way, it will use the same set of options without having to duplicate them.

@belav belav added the type:enhancement New feature or request label Apr 10, 2021
@belav belav added this to the Beta milestone Apr 10, 2021
@belav
Copy link
Owner Author

belav commented Apr 19, 2021

This is partially implemented, just so that we can ignore some files in csharpier-repos.
When we implement it for real, we should also probably support looking for a file in parent directories.
Scan up until you find one or until you hit the root.
If we do that though, the current exclude option won't work, because it expects paths relative to where the file is.

@belav
Copy link
Owner Author

belav commented Apr 24, 2021

We may want to implement ignored/exluded files using a .csharpierignore file instead. Or we could potentially support both, if the file exists in either exclude of is in a .csharpierignore, then ignore it.
We should also support YAML as well as JSON to give the people options.

@belav belav closed this as completed May 2, 2021
@belav belav added the duplicate This issue or pull request already exists label May 2, 2021
@belav belav removed this from the Beta milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant