Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Flake8 Pytest plugin #220

Merged
merged 3 commits into from Oct 23, 2021
Merged

Use the Flake8 Pytest plugin #220

merged 3 commits into from Oct 23, 2021

Conversation

SkeletalDemise
Copy link
Contributor

@SkeletalDemise SkeletalDemise commented Oct 20, 2021

⚠ Pull Requests not made with this template will be automatically closed 🔥

Prerequisites

Why do we need this pull request?

Adds the Flake8 Pytest plugin and removes the CI Pytest CLI version. This makes it like the other linters and it's easier for contributors to run.

What GitHub issues does this fix?

N/A

Copy / paste of output

N/A

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #220 (67de66b) into main (85f74cd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   92.55%   92.57%   +0.01%     
==========================================
  Files          14       15       +1     
  Lines        1209     1212       +3     
==========================================
+ Hits         1119     1122       +3     
  Misses         90       90              
Impacted Files Coverage Δ
conftest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f74cd...67de66b. Read the comment docs.

@SkeletalDemise SkeletalDemise changed the title Use the Flake8 Pylint plugin Use the Flake8 Pytest plugin Oct 21, 2021
Adds the Flake8 Pytest plugin and removes the CI Pytest CLI version. This makes it like the other linters and it's easier for contributors to run.

Fix Flake8 warnings and errors

Fixed the Flake8 config.
.flake8 Outdated Show resolved Hide resolved
@bee-san
Copy link
Owner

bee-san commented Oct 22, 2021

it's easier for contributors to run.

Why?

@SkeletalDemise
Copy link
Contributor Author

it's easier for contributors to run.

Why?

Because now contributors can just run pytest to run all the tests including Flake8 instead of having to install Flake8 and run it separately with the CLI.

@bee-san
Copy link
Owner

bee-san commented Oct 23, 2021

image 😉

@bee-san bee-san merged commit 1bdab9e into bee-san:main Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants