Skip to content

Use perma links on nodes tree #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2021

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Jun 11, 2021

Changes Made

This PR adds perma links on tree view, so we can easily go to an specific job details page from tree view.

Potential Risks

No potential risks

Test Plan

  1. Go to example directory
  2. Run npm run start:bullmq_with_flows
  3. Go to the first flow connection
  4. Create a flow, for example using:
{
  "name": "parent-job",
    "queueName": "name_of_my_parent_queue",
    "data": {},
    "children": [
      {"name": "child","data": {"idx": 0, "fo": "bar"}, "queueName":"name_of_my_queue"}
    ]
}

  1. You should see the tree view and if you click to the name of each node, you should go to that job detail
  2. Also if you look for that flow using, same behaviour of perma links should work.

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

Sorry, something went wrong.

@roggervalf
Copy link
Collaborator Author

Please @bradvogel when you get a chance, some 👀 on this pr.
Thank you very much


if (children && children.length > 0) {
return {
text,
nodes: children.map((child) => formatToTreeView(child)),
// href,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind removing commented out code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about that, I addressed it in last commit

@roggervalf roggervalf requested a review from bradvogel June 14, 2021 03:13
@bradvogel bradvogel merged commit 7a15724 into bee-queue:master Jun 14, 2021
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@roggervalf roggervalf deleted the perma-link-on-tree-view branch June 15, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants