Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken CI workflow due to incompatible NPM and Node versions #2121

Open
mhnaeem opened this issue Nov 28, 2022 · 1 comment
Open

Broken CI workflow due to incompatible NPM and Node versions #2121

mhnaeem opened this issue Nov 28, 2022 · 1 comment

Comments

@mhnaeem
Copy link
Contributor

mhnaeem commented Nov 28, 2022

Description

The Github action workflows are broken due to incompatible new version of NPM being run against Node. The offending code is below, it can easily be fixed if I can find out the original reason for its existence.
https://github.com/beautify-web/js-beautify/blob/12bc378bd465dc8771609c4a181d49462dbf7dd1/tools/npm#L7-L11

Error:

ERROR: npm v9.1.2 is known not to run on Node.js v12.22.12. You'll need to
upgrade to a newer Node.js version in order to use this version of npm. This
version of npm supports the following node versions: `^14.17.0 || ^16.13.0 ||
>=18.0.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)

On a related note, @bitwiseman I was wondering why does this package have node, npm and python* scripts in the tools directory. Those scripts make it hard to use any of the language engines on individual machines. A better alternative would be to have Docker files to run commands instead of updating packages on every computer that runs the tests or build code.

@mhnaeem mhnaeem changed the title Broken CI workflow due to incompatible NPM versions Broken CI workflow due to incompatible NPM and Node versions Nov 28, 2022
@bitwiseman
Copy link
Member

bitwiseman commented Jun 1, 2023

@mhnaeem
I fixed the GHA workflows.
These scripts were started before I docker was a thing. Or at least before I understood how to use it.
PRs welcome to convert to a docker based system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants