[Bug] beartype.door permissively accepts unsubscripted typing.Optional and typing.Union type hint factories as akin to typing Gods!? 😱

[sylvorg]

Hello! Guess who's back! ... I'm not doing that joke again, you can't make me! 😤

Get ready for a deluge of replies, starting with this issue! ... At least I think it's an issue!

Is everything supposed to match a Union generic when using beartype.door.is_bearable and beartype.door.is_subhint? For example, with the following block:

from beartype.door import is_bearable, is_subhint
from collections.abc import Callable, Iterable
from typing import Literal, Union

for t in (
    str | int,
    Union,
    Union[str, int],
    Callable,
    Callable[..., ...],
    Iterable,
    Iterable[str],
    Literal,
    Literal[1, 2],
):
    assert is_bearable(t, Union)
    assert is_subhint(t, Union)

No AssertionError occurs. I'd really like to switch to is_subhint, because then I wouldn't have to worry about issubclass erroring out on annotations like Union[...], etc., and using typing.get_origin all the time! 😅

Thank you kindly for the help!

---

P.S.: I passed the graphics course! 😻 I got a D, but still. A win is a win. 😹

[leycec]

Yay!!! It's my favourite silver Borg, @sylvorg. He's right about everything, of course. @beartype should definitely be rejecting unsubscripted type hint factories that otherwise have no semantic meaning like:

• typing.Literal. Think we nailed this one recently? I dimly recall nailing this. Stay down when I put you down, bugs!
• typing.Optional. 😢
• typing.Union. 😭
• Probably others.

Who cares about those, though! We've got an unsubscripted Union to crush.

using typing.get_origin all the time!

P.S.: I passed the graphics course! 😻 I got a D, but still. A win is a win. 😹

[sylvorg]

Yay!!! It's my favourite silver Borg, @sylvorg.

Technically, Sylveon plus:

But yes. 😹

This issue is quite exciting because it could reduce quite a bit of code on my end! 😻