Add mix.exs #99
Merged
Add mix.exs #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows Elixir to compile the project without shelling out to Rebar 3, which is useful in low memory environments. Generally speaking, I wouldn't say this is a requirement for projects, but given telemetry usage is widespread, it makes sense to optimize it to different build tools. The only downside is that the vsn can no longer be hardcoded to "git". For this reason, we also introduce a "RELEASE.md" file with steps to release a new version (which already requires some extra steps due to the use of ExDoc for docs).
josevalim
commented
Oct 20, 2021
RELEASE.md
Outdated
| 2. Update version in `docs.sh` | ||
| 3. Run `./docs.sh` | ||
| 4. Run `rebar3 hex publish` | ||
| 5. Run `rebar3 hex docs` |
There was a problem hiding this comment.
@arkgil can you please confirm these steps are correct?
There was a problem hiding this comment.
Both rebar commands need to be run as docs. Otherwise looks good - we'll update on the next release of it's not accurate 😅
josevalim
commented
Oct 21, 2021
|
@arkgil other than that, are you happy with this? If so, can I get your seal of approval? :) |
arkgil
approved these changes
Oct 21, 2021
|
Granted!
|
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Elixir to compile the project without shelling
out to Rebar3, which is useful in low memory environments.
Generally speaking, I would say this is not a requirement for
projects, but given telemetry usage is widespread, it makes
sense to optimize it to different build tools.
The only downside is that the vsn can no longer be hardcoded
to "git". For this reason, we also introduce a "RELEASE.md"
file with steps to release a new version (which already
requires some extra steps due to the use of ExDoc for docs).