Add monotonic_time to span measurements #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
force-pushed
the
jv-monotonic
branch
from
19e72e5
to
7fabd25
Compare
arkgil
previously approved these changes
Aug 13, 2021
Co-authored-by: Arek Gil <arkadiusz@arkgil.net>
joaothallis
approved these changes
Aug 15, 2021
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not add this originally because we said we were waiting for a use case. Well, the use case has arrived: we are using telemetry events to measure the idle time (the time between the last stop and the next start event). :) This helps us do that without recomputing the monotonic times. In terms of costs, the added costs here are negligent (1 word extra in the map values tuple).