Guard telemetry:execute/3 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkgil
approved these changes
Feb 1, 2022
GregMefford
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
As discussed in Slack, this enforces that all telemetry that is executed can actually be attached-to, whereas before, it was possible to execute using an event name that could never be attached-to, since attach ensures it is a list.
The danger here would be that a library or application code would be doing this incorrectly and would now crash instead of just not doing anything. In that case, upgrading Telemetry to use this code would hopefully let them know quickly that there was a problem and they could roll back to the previous version of Telemetry until the incorrect code can be updated.
bryannaegele
approved these changes
Feb 1, 2022
|
@GregMefford you are awesome for adding the context here, thanks. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.