Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFRS - Hide certain Assessment section messaging for supplemental reports until after the govt analyst makes a recommendation #2371

Open
1 task
justin-lepitzki opened this issue Jun 14, 2023 · 0 comments
Labels
Low Low priority Main release For immediate release into production when ready Task Any work that does not directly impact the user

Comments

@justin-lepitzki
Copy link
Collaborator

justin-lepitzki commented Jun 14, 2023

Background:
When the government analyst makes a recommendation on a submitted compliance report, a preview of the assessment section is displayed. This preview includes messaging, "If accepted the following information will become visible to [fuel supplier organization name]". Before the analyst makes a recommendation, there is no assessment section displayed for an original compliance report (status: submitted; no supplemental reports). This messaging continues to be displayed until the Director accepts the compliance report, at which time it is removed from the UI.

When a supplemental report is submitted after the original report was accepted, the gov't analyst can view the report and see the assessment section from the original report. When the analyst makes a recommendation on the supplemental report, the assessment section will be updated to reflect the new information (i.e., includes a new sentence that provides information about how the credit balance will change).

Currently, the messaging "if accepted the following information will become visible to [fuel supplier organization name]" is being displayed immediately after the supplemental report is submitted. This is misleading as the assessment section does not get updated to reflect the new information contained in the supplemental report until the gov't analyst makes a recommendation on the newly submitted supplemental report.

Describe the task
The task is to hide the messaging "if accepted the following information will become visible to [fuel supplier organization name]" for a newly submitted supplemental report (status = submitted) when the original or previous supplemental report has been accepted (status = accepted).

Purpose
This task is needed as the current implementation is misleading in that the messaging implies that the assessment section from the previous report is what will be displayed if the director accepts the report. However, the assessment section then changes when the analyst makes a recommendation (it gets updated based on the supplemental report information; specifically the credit balance change).

Acceptance Criteria

  • Should hide the card for the newly submitted supplemental report (status = submitted) when the original or previous supplemental report has been accepted.

Additional context

Screenshot:
Screenshot 2023-06-14 1.png

@justin-lepitzki justin-lepitzki added Low Low priority Task Any work that does not directly impact the user labels Jun 14, 2023
@justin-lepitzki justin-lepitzki added the Main release For immediate release into production when ready label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Low priority Main release For immediate release into production when ready Task Any work that does not directly impact the user
Projects
None yet
Development

No branches or pull requests

1 participant