Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding layer of refresh and additional wait to UI CLAB Artifactory test #1199

Closed
funtigr opened this issue Oct 27, 2023 · 2 comments
Closed
Assignees

Comments

@funtigr
Copy link
Collaborator

funtigr commented Oct 27, 2023

The Cypress test of UI of CLAB Artifactory is sending a lot of notifications.
Previously I fixed it by adding a custom timeout and it failed more rarely.
Now we need to add additional layer of wait and a page refresh.

Definition of Done:
The tests do not send faulty messages unless the Artifactory UI (JFrog) is completely dead.

@funtigr funtigr self-assigned this Oct 27, 2023
@funtigr
Copy link
Collaborator Author

funtigr commented Nov 1, 2023

This is a list of PRs made on this task with different versions of the solution which all don't work well.
bcgov/put#44
bcgov/put#45
bcgov/put#46
bcgov/put#47
bcgov/put#48

Official documentation of Cypress says it doesn't normally support conditional testing but there are workarounds: https://docs.cypress.io/guides/core-concepts/conditional-testing#The-problem

Also I face the Cypress core bug with promises which is well-known but not fixed: cypress-io/cypress#2979

I still believe it's possible and will continue working on it in the background.

@funtigr
Copy link
Collaborator Author

funtigr commented Nov 1, 2023

I've came up with a simple solution of trying to log in with wrong user.
In this case a call to API and then to Users database is made. Then the error message is shown.
The new test asserts the error message to contain text about incorrect username/password.
The link to PR: bcgov/put#49

@funtigr funtigr closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant