Async http adapter: only consider real requests to be real #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonywok
changed the title
This was causing an issue in VCR, as callbacks were always firing because net connect was enabled. In this case, continuously appending recorded cassettes. A stubbed request is not a real request, and therefore shouldn’t fire callbacks that are only meant for real requests.
tonywok
force-pushed
the
ts-async-real-request
branch
from
8861d17
to
7112541
Compare
This was referenced Feb 24, 2021
|
It's now released as 3.11.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an issue in VCR, as callbacks were always firing because net connect was enabled. In this case, continuously appending recorded cassettes.
A stubbed request is not a real request, and therefore shouldn’t fire callbacks that are only meant for real requests.
Note this was made in collaboration with the fix identified by @ioquatix in #930