Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with async-http 0.54+ #923

Merged
merged 1 commit into from Jan 13, 2021

Conversation

jasl
Copy link
Contributor

@jasl jasl commented Jan 12, 2021

async-http switch to keyword arguments: socketry/async-http@3e967d4

because its signature

def initialize(endpoint, protocol = endpoint.protocol, scheme = endpoint.scheme, authority = endpoint.authority, retries: DEFAULT_RETRIES, connection_limit: DEFAULT_CONNECTION_LIMIT)

def initialize(endpoint, protocol: endpoint.protocol, scheme: endpoint.scheme, authority: endpoint.authority, retries: DEFAULT_RETRIES, connection_limit: DEFAULT_CONNECTION_LIMIT)

This should be the easist way to keeping compatibility

@jasl
Copy link
Contributor Author

jasl commented Jan 12, 2021

  1) The library itself has no malformed whitespace
     Failure/Error: expect(error_messages.compact).to be_well_formed
       CHANGELOG.md has spaces on the EOL on lines 7
     # ./spec/quality_spec.rb:72:in `block (2 levels) in <top (required)>'
     # ./lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

seems not my mistake

@bblimke
Copy link
Owner

bblimke commented Jan 13, 2021

Thank you @jasl

@bblimke bblimke merged commit 881c355 into bblimke:master Jan 13, 2021
@jasl jasl deleted the fix-compatible-with-async-http-0_54 branch January 13, 2021 09:58
@jasl
Copy link
Contributor Author

jasl commented Jan 13, 2021

Thank you @jasl

Thanks for your wonderful gem!

BTW, could you release a new version?

@bblimke
Copy link
Owner

bblimke commented Jan 13, 2021

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants