Revert inversion of pattern check in URIPattern constructor #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bblimke#903. This reinstates `WebMock::Util::URI.normalize_uri` as the default fallback behavior of the constructor, specifically whitelisting callable objects, in addition to the classes that were previously whitelisted, to pass through unchanged.
|
Hi @leboshi Thank you for the detailed explanation and a PR well covered with tests 👍 |
|
It's now released as 3.9.1 |
|
Thank YOU for the fast merge and re-release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #903.
This reinstates
WebMock::Util::URI.normalize_urias the default fallback behavior of the constructor, specifically whitelisting callable objects, in addition to the classes that were previously whitelisted, to pass through unchanged.Also corrected descriptions of some existing specs that didn't match tested behavior.