Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async http adapter warning #902

Merged
merged 1 commit into from Sep 11, 2020

Conversation

bruno-
Copy link
Contributor

@bruno- bruno- commented Sep 8, 2020

Problem: when using async http adapter rspec outputs the following warning
lib/webmock/http_lib_adapters/async_http_client_adapter.rb:154: warning: instance variable @alpn_protocol not initialized
Reason for that is: @alpn_protocol is never defined.

Solution: don't use @alpn_protocol

Problem: when using async http adapter rspec outputs the following
warning
`lib/webmock/http_lib_adapters/async_http_client_adapter.rb:154: warning: instance variable @alpn_protocol not initialized`
Reason for that is: `@alpn_protocol` is never defined.

Solution: don't use `@alpn_protocol`
@bblimke
Copy link
Owner

bblimke commented Sep 11, 2020

Thank you @bruno-

@bblimke bblimke merged commit 4ae891b into bblimke:master Sep 11, 2020
@bruno- bruno- deleted the async_http_adapter_warning branch September 11, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants