Fix invalid scheme error with Addressable::Template

[uiur]

Fix #489

problem

Addressable::Template#match expects a valid uri with scheme
sporkmonger/addressable#208 (comment)

It works with most cases without uri scheme, but it raises an error with some cases like 127.0.0.1:8080.

I've found that it causes the error when using webmock with System Spec and chrome driver.

solution

Always pass a uri with scheme to Addressable::Template#match.

The difference from #739 is

• adding a spec
• making failing specs pass

[bblimke]

@uiureo thank you for the PR.

Could you please explain why have you removed all these urls in https://github.com/bblimke/webmock/pull/758/files#diff-a5f6621858e36a69278262b16c576604 ?

These urls were there to guarantee that WebMock can match urls without scheme provided with urls with the default scheme, which is not the case anymore.
As I understand this change breaks backwards compatibility?

[uiur]

Ah I understand. This is mistake.
I will fix it in a way that it doesn't change WebMock::Util::URI.variations_of_uri_as_strings.

[uiur]

Added with_scheme: true option to WebMock::Util::URI.variations_of_uri_as_strings instead.

@bblimke How do you think?

[bblimke]

I'm not sure I understand the with_scheme flag here. The condition is "if not with scheme" and the line below compares returns values with scheme and without.

[uiur]

The flag means "returns only variations with scheme", but I agree it's confusing.

only_variations_with_scheme might be better?

[bblimke]

Yes only_with_scheme would be more meaningful.

[uiur]

updated 1962400

[uiur]

@bblimke Could you review this again?

[bblimke]

@uiureo sorry. Looks good. Thank you!

[bblimke]

Released as 3.4.2. Thank you!

[alain-andre]

Hi there, I'm having this issue and I'm wondering why I cannot see this fix in the latest code :

webmock/lib/webmock/request_pattern.rb

Line 190 in 904aa98

WebMock::Util::URI.variations_of_uri_as_strings(uri).any? { |u| template.match(u) }

It has been remove on commit

I do not understand why in the UT it adds the only_with_scheme of the WebMock::Util::URI.variations_of_uri_as_strings method but removes it from the request_pattern class.

Any idea ?

[bblimke]

@alain-andre it has been removed due to this issue #828

The problem was that the only_with_scheme solution is not complete.

Hopefully the issue will be resolved once #890 is finished. @guppy0356