-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Cypress promise exception handler #9457
Conversation
@jroebu14 I think this what you were after in the linked issue? I tested the removal of that block of code to handle promises in Cypress, and the tests appear to pass as normal. Not sure what has changed, but perhaps all the promises are having their rejections handled correctly and/or the tests for them are also being handled correctly. Can't see anything in the release notes from v7 to v8.2.0 that suggests any changes have been made to revert unhandled exceptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah brilliant. thanks for picking this one up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #9178
Overall change:
Removes condition that allowed unhandled promise exceptions to pass Cypress in tests.
Code changes:
cypress/support/index.js
that allowed unhandled promise exceptions to not fail Cypress testswindow:before:load
listener as the stubbing function syntax used is now deprecated.cross-team
label to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive
)