Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2] Emotion PoC – SSR Perf. #7536

Closed
1 task done
simonsinclair opened this issue Aug 18, 2020 · 1 comment
Closed
1 task done

[2/2] Emotion PoC – SSR Perf. #7536

simonsinclair opened this issue Aug 18, 2020 · 1 comment
Assignees
Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features ws-articles Tasks for the WS Articles Team
Projects

Comments

@simonsinclair
Copy link
Contributor

simonsinclair commented Aug 18, 2020

Part 2 of bbc/psammead#3677.

Is your feature request related to a problem? Please describe.

We know from the profiling conducted in #6922 that upgrading to Styled Components v5 will grant us an additional 17% (~4 requests/sec) server throughput.

Unfortunately Styled Components v5 has a bad interaction with two companion packages we're using. These issues were raised last year and are yet to be resolved.

Additionally, Styled Components v4 dependencies have severe vulnerabilities.

We need to solve this as soon as possible and would like to trial a competitor CSS-in-JS library – Emotion.

Describe the solution you'd like

  • Remove Styled Components and companion packages.
  • Install Emotion and companion packages.
  • Bump Psammead packages to RC version created in [1/2] Emotion PoC – SSR Perf. psammead#3677.
  • Update SSR stylesheet rendering logic to use Emotion.

Describe alternatives you've considered

Remove jest-styled-components and babel-plugin-styled-components - meaning no styles in snapshots. This isn't really an alternative.

Testing notes

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context

n/a

@simonsinclair simonsinclair added ws-articles Tasks for the WS Articles Team technical-work Technical debt, support work and building new technical tools and features cross-team For visibility for both World Service teams (Engage & Media) labels Aug 18, 2020
@simonsinclair simonsinclair added this to Coming Soon in Simorgh Aug 18, 2020
@joshcoventry joshcoventry moved this from Coming Soon to Issue in Progress in Simorgh Sep 3, 2020
@simonsinclair
Copy link
Contributor Author

This work is complete. Please see #7772.

Simorgh automation moved this from Issue in Progress to Done Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features ws-articles Tasks for the WS Articles Team
Projects
No open projects
Development

No branches or pull requests

1 participant