Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Psammead not generating Chromatic Snapshots in IE #4519

Closed
ryanmccombe opened this issue Jul 14, 2021 · 0 comments · Fixed by #4520
Closed

Psammead not generating Chromatic Snapshots in IE #4519

ryanmccombe opened this issue Jul 14, 2021 · 0 comments · Fixed by #4520
Assignees
Labels
bug Something isn't working
Projects

Comments

@ryanmccombe
Copy link
Contributor

ryanmccombe commented Jul 14, 2021

Describe the bug
Chromatic is not working in IE for Psammead

See builds like this: https://www.chromatic.com/build?appId=5d28eb5ee163f6002046d6fb&number=10175

Error message:

WARN ./packages/components/psammead-image/src/index.stories.jsx
WARN Module build failed (from ./node_modules/@storybook/builder-webpack4/node_modules/babel-loader/lib/index.js):
WARN SyntaxError: /Users/mccomr01/psammead/packages/components/psammead-image/src/index.stories.jsx: Invalid left-hand side in assignment expression. (12:0)
WARN 
WARN   10 |
WARN   11 |
WARN > 12 | image-without-width.parameters = { storySource: { source: "() => <Img {...getProps(landscape, false, type)} width={null} />" }, ...image-without-width.parameters };
WARN      | ^
WARN     at Object._raise (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:816:17)
WARN     at Object.raiseWithData (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:809:17)
WARN     at Object.raise (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:770:17)
WARN     at Object.checkLVal (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:10472:16)
WARN     at Object.parseMaybeAssign (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:10655:12)
WARN     at Object.parseExpressionBase (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:10573:23)
WARN     at /Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:10567:39
WARN     at Object.allowInAnd (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:12328:16)
WARN     at Object.parseExpression (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:10567:17)
WARN     at Object.parseStatementContent (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:12665:23)
WARN     at Object.parseStatement (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:12534:17)
WARN     at Object.parseBlockOrModuleBlockBody (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:13123:25)
WARN     at Object.parseBlockBody (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:13114:10)
WARN     at Object.parseProgram (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:12457:10)
WARN     at Object.parseTopLevel (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:12448:25)
WARN     at Object.parse (/Users/mccomr01/psammead/node_modules/@babel/parser/lib/index.js:14175:10)
WARN  @ \.)(?=.)[^/]*?\.stories\.jsx)$ (./packages sync ^\.\/(?:(?!\.)(?=.)[^/]*?\/(?!\.)(?=.)[^/]*?\/(?!\.)(?=.)[^/]*?\/(?!\.)(?=.)[^/]*?\.stories\.jsx)$) ./components/psammead-image/src/index.stories.jsx
WARN  @ ./.storybook/generated-stories-entry.js
WARN  @ multi ./node_modules/@storybook/core-client/dist/esm/globals/polyfills.js ./node_modules/@storybook/core-client/dist/esm/globals/globals.js ./.storybook/storybook-init-framework-entry.js ./node_modules/@storybook/addon-docs/dist/esm/frameworks/common/config.js-generated-other-entry.js ./node_modules/@storybook/addon-docs/dist/esm/frameworks/react/config.js-generated-other-entry.js ./node_modules/@storybook/addon-knobs/dist/esm/preset/addDecorator.js-generated-other-entry.js ./node_modules/@storybook/addon-a11y/dist/esm/a11yRunner.js-generated-other-entry.js ./node_modules/@storybook/addon-a11y/dist/esm/a11yHighlight.js-generated-other-entry.js ./.storybook/preview.js-generated-config-entry.js ./.storybook/generated-stories-entry.js

https://storybook.js.org/docs/react/configure/babel
storybookjs/storybook#14578

@ryanmccombe ryanmccombe added the bug Something isn't working label Jul 14, 2021
@ryanmccombe ryanmccombe added this to Coming Soon in Simorgh via automation Jul 14, 2021
@ryanmccombe ryanmccombe moved this from Coming Soon to Issue in Progress in Simorgh Jul 14, 2021
@ryanmccombe ryanmccombe self-assigned this Jul 14, 2021
@ryanmccombe ryanmccombe changed the title Chromatic not Generating Snapshots in IE Psammead not generating Chromatic Snapshots in IE Jul 14, 2021
@ryanmccombe ryanmccombe mentioned this issue Jul 14, 2021
4 tasks
Simorgh automation moved this from Issue in Progress to Done Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant